<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2271#discussion_r317353204">src/build.c</a>:</p>
<pre style='color:#555'>> @@ -817,7 +816,8 @@ static gchar *prepare_run_cmd(GeanyDocument *doc, gchar **working_dir, guint cmd
        {
                if (vc->skip_run_script)
                {
-                       utils_free_pointers(2, cmd_string_utf8, working_dir_utf8, NULL);
+                       utils_free_pointers(3, cmd_string_utf8, working_dir_utf8,
+                               *working_dir, NULL);
</pre>
<p>Yeah, and as in this code path the function doesn't return <code>NULL</code> (or shouldn't, at least), it's expected that <code>*working_dir</code> contains the working directory.</p>
<p>I think this change is wrong.  <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1107820" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ntrel">@ntrel</a> did you actually measure a memory leak, or can this be coming from a misinterpretation of the code? (which might suggest it should be made clearer, but well)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2271?email_source=notifications&email_token=AAIOWJ2DKHSS7LH2JVXIZUTQGEEKXA5CNFSM4IPBC37KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSYX2Q#discussion_r317353204">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ57XS2DB7VRPUDH2SLQGEEKXANCNFSM4IPBC37A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ5P4ZGBGPGOMQNJ6DTQGEEKXA5CNFSM4IPBC37KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSYX2Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2271?email_source=notifications\u0026email_token=AAIOWJ2DKHSS7LH2JVXIZUTQGEEKXA5CNFSM4IPBC37KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSYX2Q#discussion_r317353204",
"url": "https://github.com/geany/geany/pull/2271?email_source=notifications\u0026email_token=AAIOWJ2DKHSS7LH2JVXIZUTQGEEKXA5CNFSM4IPBC37KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSYX2Q#discussion_r317353204",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>