<ul>
<li>HACKING: Avoid untyped pointers & <code>*_foreach()</code> with non-NULL <code>user_data</code> void pointer where practical.</li>
<li>build.c: Avoid <code>g_ptr_array_foreach</code> with <code>user_data</code> void pointer - this also means we can get rid of the singleton <code>ForEachData</code>, which simplifies the code quite a bit.</li>
</ul>
<p>Note: <code>GPtrArray</code> is already not typesafe, but it does support external iteration, which allows us to avoid passing the address of typed data to a <code>user_data</code> void pointer, which is another violation of type safety.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/2270'>https://github.com/geany/geany/pull/2270</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>build.c: Remove g_ptr_array_foreach with untyped user_data</li>
  <li>HACKING: Avoid untyped pointers & *_foreach() with non-NULL user_data</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/2270/files#diff-0">HACKING</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/2270/files#diff-1">src/build.c</a>
    (41)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/2270.patch'>https://github.com/geany/geany/pull/2270.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/2270.diff'>https://github.com/geany/geany/pull/2270.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2270?email_source=notifications&email_token=AAIOWJ6UGQYQIZNTVYQMVN3QF23W3A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HG2UQPQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZ2NEWBDYBO64PJ2ADQF23W3ANCNFSM4IOW2V4A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZPD5553345ISO4W6TQF23W3A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HG2UQPQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2270?email_source=notifications\u0026email_token=AAIOWJ6UGQYQIZNTVYQMVN3QF23W3A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HG2UQPQ",
"url": "https://github.com/geany/geany/pull/2270?email_source=notifications\u0026email_token=AAIOWJ6UGQYQIZNTVYQMVN3QF23W3A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HG2UQPQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>