<p>There are other refactorings for build.c of higher priority IMO than adding braces or refactoring expressions in assign_cmd (which is short). I support using an intermediate variable for common expressions, but this should be done for bigger functions in build.c first.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2256?email_source=notifications&email_token=AAIOWJ2ZXFGQ76PCAZ2UA6LQEK6EVA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FY4VI#issuecomment-520851029">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3YYC26PFP3OQEVVK3QEK6EVANCNFSM4ILBSKBA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ2B3GCF3BLZGSE466TQEK6EVA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FY4VI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2256?email_source=notifications\u0026email_token=AAIOWJ2ZXFGQ76PCAZ2UA6LQEK6EVA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FY4VI#issuecomment-520851029",
"url": "https://github.com/geany/geany/pull/2256?email_source=notifications\u0026email_token=AAIOWJ2ZXFGQ76PCAZ2UA6LQEK6EVA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FY4VI#issuecomment-520851029",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>