<p><b>@kugel-</b> requested changes on this pull request.</p>

<p>I think the commit message lacks a bit of story. Yes, the change fixes a TODO in the code but the message could mention just that.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2256#discussion_r313230271">src/build.c</a>:</p>
<pre style='color:#555'>> @@ -2291,6 +2291,22 @@ static void build_load_menu_grp(GKeyFile *config, GeanyBuildCommand **dst, gint
 }
 
 
+/* set GeanyBuildCommand if it doesn't already exist and there is a command */
+static void assign_cmd(GeanyBuildCommand *type, guint id,
+               const gchar *label, gchar *value)
+{
+       if (!EMPTY(value) && ! type[GBO_TO_CMD(id)].exists)
+       {
+               type[GBO_TO_CMD(id)].exists = TRUE;
+               SETPTR(type[GBO_TO_CMD(id)].label, g_strdup(label));
+               SETPTR(type[GBO_TO_CMD(id)].command, value);
+               SETPTR(type[GBO_TO_CMD(id)].working_dir, NULL);
+               type[GBO_TO_CMD(id)].old = TRUE;
</pre>
<p>The readablity could be improved by using a temporary variable for <code>GBO_TO_CMD(id)</code> or even the whole <code>type[GBO_TO_CMD(id)</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2256?email_source=notifications&email_token=AAIOWJ3RDM7LU7YK4P24Z43QEJE6HA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBLAVKA#pullrequestreview-274074280">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ72FOQE4ZPW5TXDNOTQEJE6HANCNFSM4ILBSKBA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZF3RQZVKWKQZ5Y2N3QEJE6HA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBLAVKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2256?email_source=notifications\u0026email_token=AAIOWJ3RDM7LU7YK4P24Z43QEJE6HA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBLAVKA#pullrequestreview-274074280",
"url": "https://github.com/geany/geany/pull/2256?email_source=notifications\u0026email_token=AAIOWJ3RDM7LU7YK4P24Z43QEJE6HA5CNFSM4ILBSKBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBLAVKA#pullrequestreview-274074280",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>