<p>Maybe I missed something but on my system it doesn't seem to work. Hitting ctrl+f does nothing, wit h either top or bottom options. With the "none" option the dialog appears.</p>
<p>Also, some more opinions from my side:</p>
<ol>
<li>I would accept this only if it can replace the search dialog entirely, including replace functionality.</li>
<li>Since it's a new UI for existing functionality there shouldn't be much code churn</li>
<li>While I agree to enable it by default, I think existing installations shouldn't be switched over.</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2220?email_source=notifications&email_token=AAIOWJZV475CUFFIKTWGPGTQDEAILA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3T24IQ#issuecomment-518499874">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5BCI5KHDJ7QNNPHGDQDEAILANCNFSM4IEKN7DQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJYLZK7P2VU4UNJ5TKDQDEAILA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3T24IQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJZV475CUFFIKTWGPGTQDEAILA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3T24IQ#issuecomment-518499874",
"url": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJZV475CUFFIKTWGPGTQDEAILA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3T24IQ#issuecomment-518499874",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>