<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=37348338" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/js361014">@js361014</a> my only issue with the actual change is that it doesn't include the Search and Replace, so now there's different UIs for normal find (dialog, search bar, toolbar) and Replace (dialog) and Find In Files (dialog).</p>
<p>Other than that I'm just unclear why this has to go into core instead of a plugin like would normally be done. I'd like to hear from some other core devs whether we're going to start bringing in additions to core which could/should go in plugins. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=617017" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1010248" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/frlan">@frlan</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1107820" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ntrel">@ntrel</a>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2220?email_source=notifications&email_token=AAIOWJ7Z4CPQ5DILNSIAGRDQB52XDA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3CIV7A#issuecomment-516197116">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4PHHBUJHHRVFFHLWLQB52XDANCNFSM4IEKN7DQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ34QCRHRDAA4AG4UHLQB52XDA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3CIV7A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJ7Z4CPQ5DILNSIAGRDQB52XDA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3CIV7A#issuecomment-516197116",
"url": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJ7Z4CPQ5DILNSIAGRDQB52XDA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3CIV7A#issuecomment-516197116",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>