Am 30. Juli 2019 01:14:57 MESZ schrieb Matthew Brush <notifications@github.com>:<br>
>@js361014 my only issue with the actual change is that it doesn't<br>
>include the Search and Replace, so now there's different UIs for normal<br>
>find (dialog, search bar, toolbar) and Replace (dialog) and Find In<br>
>Files (dialog).<br>
<br>
True, in my view the bar would entirely replace the dialog (which is driving me nuts on my 3 monitor setup), i.e. the dialog ui would move into the bar, probably with some tweaks. I wouldn't except yet another search UI if it cannot fully replace an existing one.<br>
<br>
<br>
<br>
><br>
>Other than that I'm just unclear why this has to go into core instead<br>
>of a plugin like would normally be done. I'd like to hear from some<br>
>other core devs whether we're going to start bringing in additions to<br>
>core which could/should go in plugins. @b4n @eht16 @frlan @ntrel?<br>
<br>
<br>
Its always a case-by-case discussion, there is no general rule that every enhancement that can possibly be implemented in a plugin must be implemented in a plugin. The author would rather see it in the core so thats what he has spent his time on. I support him in this case because I hate the dialog and the "offload small but useful features to fire-and-forget plugins" methodology in general.<br>
<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2220?email_source=notifications&email_token=AAIOWJZ6GLPGZGL44JW24OLQB7GU3A5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3C2CVA#issuecomment-516268372">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZNHV2QPAVJHKOOJGTQB7GU3ANCNFSM4IEKN7DQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6672JXGPLZ5UWDBKTQB7GU3A5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3C2CVA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJZ6GLPGZGL44JW24OLQB7GU3A5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3C2CVA#issuecomment-516268372",
"url": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJZ6GLPGZGL44JW24OLQB7GU3A5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3C2CVA#issuecomment-516268372",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>