<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2220#discussion_r307951328">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> +    vbox = gtk_widget_get_ancestor(page, GTK_TYPE_VBOX);
+       GList *vbox_children = gtk_container_get_children(GTK_CONTAINER(vbox));
+       GtkWidget *sbox;
+       if (interface_prefs.search_bar_position == SEARCH_BAR_POSITION_TOP)
+       {
+               sbox = (GtkWidget*)vbox_children->data;
+       }
+       else
+       {
+               sbox = (GtkWidget*)((GList*)g_list_last(vbox_children))->data;
+       }
+       g_list_free(vbox_children);
+       return sbox;
+}
+
+void ui_emit_entry_what_to_search_in_search_bar_changed_if_visible(GeanyDocument *doc)
</pre>
<p><g-emoji class="g-emoji" alias="astonished" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f632.png">😲</g-emoji></p>
<p>Not to bikeshed, but it might be useful to spend some of those characters explaining what <code>sbox</code> is inside the function. Perhaps it could be shortened to <code>ui_emit_search_bar_entry_changed</code>? Likewise for below, it could be something like <code>ui_emit_search_bar_close_button_clicked</code>. While I'm a big fan of descriptive function names, it doesn't necessarily have to say everything the function does.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2220?email_source=notifications&email_token=AAIOWJZVEB3EAABEU7QR2GLQBO6MVA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7YQKUA#pullrequestreview-267453776">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7BPN57KZ3L3ZOZFH3QBO6MVANCNFSM4IEKN7DQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZD5BKHJLVLHIEY7TTQBO6MVA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7YQKUA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJZVEB3EAABEU7QR2GLQBO6MVA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7YQKUA#pullrequestreview-267453776",
"url": "https://github.com/geany/geany/pull/2220?email_source=notifications\u0026email_token=AAIOWJZVEB3EAABEU7QR2GLQBO6MVA5CNFSM4IEKN7D2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7YQKUA#pullrequestreview-267453776",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>