<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/823#discussion_r303200632">scope/src/utils.c</a>:</p>
<pre style='color:#555'>> @@ -36,6 +36,10 @@
 #ifdef G_OS_UNIX
 #include <fcntl.h>
 
+/* The maximum length of an expression for evaluating the value.
+   (Including the string terminator '\0') */
+#define SCOPE_MAX_EVALUATE_EXPR_LENGTH 256
</pre>
<p>Is it intended that the macro definition is within the <code>#ifdef G_OS_UNIX</code> block?<br>
This breaks the Windows builds: <a href="https://nightly.geany.org/win32/build_win32_plugins_stderr.log" rel="nofollow">https://nightly.geany.org/win32/build_win32_plugins_stderr.log</a> as it used unconditionally later on.</p>
<p>I assume the macro definition should be outside any OS guards?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/823?email_source=notifications&email_token=AAIOWJ432E3ULSURBWN7DKLP7GV5RA5CNFSM4GX6JSN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LLWHA#pullrequestreview-261536540">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6QNLAS74LH4NN37OLP7GV5RANCNFSM4GX6JSNQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZEB4EMIR6P7QXGFRDP7GV5RA5CNFSM4GX6JSN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LLWHA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/823?email_source=notifications\u0026email_token=AAIOWJ432E3ULSURBWN7DKLP7GV5RA5CNFSM4GX6JSN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LLWHA#pullrequestreview-261536540",
"url": "https://github.com/geany/geany-plugins/pull/823?email_source=notifications\u0026email_token=AAIOWJ432E3ULSURBWN7DKLP7GV5RA5CNFSM4GX6JSN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LLWHA#pullrequestreview-261536540",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>