<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2114#discussion_r298829919">src/keyfile.c</a>:</p>
<pre style='color:#555'>> @@ -1313,11 +1316,47 @@ void configuration_apply_settings(void)
 }
 
 
+static gboolean save_configuration_cb(gpointer data)
+{
+       configuration_save();
</pre>
<blockquote>
<p>Just continuing <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a>'s theme, do we need to save both config and project? The active session is in the project, not the config.</p>
</blockquote>
<p>Maybe we do not need to save the config if a project is open regarding the session files but for all other maybe changed settings and I think it won't hurt(except disk IO) to leave a consistent state on disk.</p>
<blockquote>
<p>And on that note, shouldn't the config be saved on project open/close as well, although it will often happen anyway because files will be opened/closed when a project opens, but not always.</p>
</blockquote>
<p>In my tests, the <code>save_configuration_cb()</code> was always called on project related actions. What exact cases do you refer to by "not always"?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2114?email_source=notifications&email_token=AAIOWJ57W6SC3QS6TGOELHTP5CLIVA5CNFSM4HCD7YRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BVFVY#discussion_r298829919">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJYK5MJMHMHRHJPEISDP5CLIVANCNFSM4HCD7YRA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3N5IUJVPABN3ZGEHLP5CLIVA5CNFSM4HCD7YRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BVFVY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2114?email_source=notifications\u0026email_token=AAIOWJ57W6SC3QS6TGOELHTP5CLIVA5CNFSM4HCD7YRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BVFVY#discussion_r298829919",
"url": "https://github.com/geany/geany/pull/2114?email_source=notifications\u0026email_token=AAIOWJ57W6SC3QS6TGOELHTP5CLIVA5CNFSM4HCD7YRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BVFVY#discussion_r298829919",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>