<p><b>@b4n</b> approved this pull request.</p>

<p>Nitpicking below, otherwise looks good <g-emoji class="g-emoji" alias="+1" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji></p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2181#discussion_r296491860">scripts/update-nsis-functions.sh</a>:</p>
<pre style='color:#555'>> +set -e
+
+TOKENS_CPP_FILE="/tmp/nsis_tokens.cpp"
+TOKENS_CPP_URL="https://raw.githubusercontent.com/kichik/nsis/master/Source/tokens.cpp"
+BUILD_CPP_FILE="/tmp/nsis_build.cpp"
+BUILD_CPP_URL="https://raw.githubusercontent.com/kichik/nsis/master/Source/build.cpp"
+DATA_FILE=data/filedefs/filetypes.nsis
+
+[ -f "${DATA_FILE}" ]
+
+# download tokens.cpp and build.cpp from NSIS
+wget --quiet --output-document="${TOKENS_CPP_FILE}" "${TOKENS_CPP_URL}"
+wget --quiet --output-document="${BUILD_CPP_FILE}" "${BUILD_CPP_URL}"
+
+normalize() {
+   sort | tr '[:upper:]' '[:lower:]' | tr '\n' ' ' | tr '\r' ' ' | sed 's/^[[:blank:]]*//;s/[[:blank:]]*$//'
</pre>
<p>You could merge the <code>tr</code> calls like that: <code>tr '[:upper:][:space:]' '[:lower:] '</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2181?email_source=notifications&email_token=AAIOWJ6FGUJUOUIMXWHOXW3P362RNA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LKRSI#pullrequestreview-253143241">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZOD6XKDHWQM67IZYTP362RNANCNFSM4HWTGO5Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3GFPS3QASR4XVURJ3P362RNA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LKRSI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2181?email_source=notifications\u0026email_token=AAIOWJ6FGUJUOUIMXWHOXW3P362RNA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LKRSI#pullrequestreview-253143241",
"url": "https://github.com/geany/geany/pull/2181?email_source=notifications\u0026email_token=AAIOWJ6FGUJUOUIMXWHOXW3P362RNA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LKRSI#pullrequestreview-253143241",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>