<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2181#discussion_r295753959">scripts/update-nsis-functions.sh</a>:</p>
<pre style='color:#555'>> +
+# extract variable names (then sort the result, conver to lowercase and replace new lines by spaces)
+variables=$(\
+    sed --silent --regexp-extended\
+        --expression 's/^[ ]*m_ShellConstants.add\(_T\("(.*)"\),.*,.*\);.*$/\1/p' \
+        --expression 's/^[ ]*m_UserVarNames.add\(_T\("(.*)"\),.*\);.*$/\1/p' "${BUILD_CPP_FILE}" | \
+    sort | \
+    tr '[:upper:]' '[:lower:]' | \
+    tr '\n' ' ')
+
+# hardcode a few more, as found in the documentation ("4.2.2 Other Writable Variables")
+variables_extra='{nsisdir} 0 1 2 3 4 5 6 7 8 9 r0 r1 r2 r3 r4 r5 r6 r7 r8 r9 \\n \\r \\t $'
+variables="${variables_extra} ${variables}"
+# prefix each element with a dollar sign
+declare -a variables_array=(${variables})
+variables="${variables_array[@]/#/'$'}"
</pre>
<p>As you say, Mr. <code>sed</code> :)<br>
While I don't mind much about the Bash dependency (this is a maintenance script to be run only by developers and only if necessary and so doesn't need to be that portable), I like the <code>sed</code> approach more than the array magic because of readability.<br>
Thanks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2181?email_source=notifications&email_token=AAIOWJ5ELE37METX6WGHMYTP3NPHXA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EJXMQ#discussion_r295753959">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ75FS23TFFWOV2M4HLP3NPHXANCNFSM4HWTGO5Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6XAUMVUT6THBYYBFDP3NPHXA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EJXMQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2181?email_source=notifications\u0026email_token=AAIOWJ5ELE37METX6WGHMYTP3NPHXA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EJXMQ#discussion_r295753959",
"url": "https://github.com/geany/geany/pull/2181?email_source=notifications\u0026email_token=AAIOWJ5ELE37METX6WGHMYTP3NPHXA5CNFSM4HWTGO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4EJXMQ#discussion_r295753959",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>