<blockquote>
<p>However, we most probably don't need to run <code>distcheck</code> on all compilers, as it's mostly checking the build system itself rather than the compilation. Only <code>all</code> (obviously) and <code>check</code> are really useful to run everywhere for a sensible test, and that might give a comfortable speed up by not building everything twice. This can be changed at some later point tho, and can probably be fixed by e.g. setting <code>TARGETS="all check distcheck"</code> in the "normal" case and removing <code>distcheck</code> in the "compiler builds", and replacing the <code>make -j2 && make -j2 check && make -j2 distcheck</code> with just <code>make -j2 $TARGETS</code>.</p>
</blockquote>
<p>I pushed a commit that addresses that. But I made the change before I reviewed your suggested approach. If you'd like it changed, please let me know.</p>
<blockquote>
<p>Anyway, the change seems a little verbose, but there might not be a shorter syntax for this (I'm no YAML expert tho).</p>
</blockquote>
<p>That's another copy/paste from the travis docs. afaik the only way to reduce the lines is to use a script that manually imports the toolchain repo and keys, and installs the appropriate gcc package.</p>
<p>However, using the the "addons/source" travis directive as it is now may be easier in the long-run, to maintain. What do you think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2067#issuecomment-488541374">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4LXQYWJO65JV7DHBLPTJMWHANCNFSM4GSODDDQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3ZTSYPUHX67IPUFLTPTJMWHA5CNFSM4GSODDD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODUPIZPQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@andy5995 in #2067: \u003e However, we most probably don't need to run `distcheck` on all compilers, as it's mostly checking the build system itself rather than the compilation. Only `all` (obviously) and `check` are really useful to run everywhere for a sensible test, and that might give a comfortable speed up by not building everything twice. This can be changed at some later point tho, and can probably be fixed by e.g. setting `TARGETS=\"all check distcheck\"` in the \"normal\" case and removing `distcheck` in the \"compiler builds\", and replacing the `make -j2 \u0026\u0026 make -j2 check \u0026\u0026 make -j2 distcheck` with just `make -j2 $TARGETS`.\r\n\r\nI pushed a commit that addresses that. But I made the change before I reviewed your suggested approach. If you'd like it changed, please let me know.\r\n\r\n\u003e \r\n\u003e Anyway, the change seems a little verbose, but there might not be a shorter syntax for this (I'm no YAML expert tho).\r\n\r\nThat's another copy/paste from the travis docs. afaik the only way to reduce the lines is to use a script that manually imports the toolchain repo and keys, and installs the appropriate gcc package.\r\n\r\nHowever, using the the \"addons/source\" travis directive as it is now may be easier in the long-run, to maintain. What do you think?\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2067#issuecomment-488541374"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2067#issuecomment-488541374",
"url": "https://github.com/geany/geany/pull/2067#issuecomment-488541374",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>