<p><b>@b4n</b> requested changes on this pull request.</p>

<p>This sounds good, but I'm not so sure how important it is to check with recent compilers -- old ones for compat, new ones… well, it certainly doesn't hurt :)  However, we most probably don't need to run <code>distcheck</code> on all compilers, as it's mostly checking the build system itself rather than the compilation.  Only <code>all</code> (obviously) and <code>check</code> are really useful to run everywhere for a sensible test, and that might give a comfortable speed up by not building everything twice.  This can be changed at some later point tho, and can probably be fixed by e.g. setting <code>TARGETS="all check distcheck"</code> in the "normal" case and removing <code>distcheck</code> in the "compiler builds", and replacing the <code>make -j2 && make -j2 check && make -j2 distcheck</code> with just <code>make -j2 $TARGETS</code>.</p>
<p>Anyway, the change seems a little verbose, but there might not be a shorter syntax for this (I'm no YAML expert tho).</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2067#discussion_r279753841">.travis.yml</a>:</p>
<pre style='color:#555'>> +      dist: xenial
+      addons:
+        apt:
+          sources:
+            - ubuntu-toolchain-r-test
+          packages:
+            - g++-8
+      env:
+        - MATRIX_EVAL="CC=gcc-8 && CXX=g++-8"
+
+# clang        
+    - os: linux
+      addons:
+        apt:
+          sources:
+            - llvm-toolchain-trusty-5.0
</pre>
<p>shouldn't you specify <code>trusy</code> as the <code>dist</code> if you use that repo?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2067#discussion_r279754693">.travis.yml</a>:</p>
<pre style='color:#555'>> +        apt:
+          sources:
+            - ubuntu-toolchain-r-test
+          packages:
+            - g++-8
+      env:
+        - MATRIX_EVAL="CC=gcc-8 && CXX=g++-8"
+
+# clang        
+    - os: linux
+      addons:
+        apt:
+          sources:
+            - llvm-toolchain-trusty-5.0
+          packages:
+            - clang-5.0
</pre>
<p>Ideally we'd test with clang 3.4 as it's supposed to be able to build Scintilla, which is our most bleeding edge.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2067#discussion_r280149461">.travis.yml</a>:</p>
<pre style='color:#555'>>  before_install:
+  - eval "${MATRIX_EVAL}"
</pre>
<p>this should be in <code>before_script</code> below with the <code>CFLAGS</code> export, shouldn't it?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2067#discussion_r280149908">.travis.yml</a>:</p>
<pre style='color:#555'>>  before_install:
+  - eval "${MATRIX_EVAL}"
</pre>
<p>Also I'd rather see this done using <code>export</code>, and set e.g. <code>MATRIX_EXPORT="CC=clang-5.0 CXX=clang++-5.0"</code>, which is effectively what we want done (and so it doesn't rely on <code>CC</code> and <code>CXX</code> being exported by something else).</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2067#discussion_r280150209">.travis.yml</a>:</p>
<pre style='color:#555'>> @@ -1,17 +1,70 @@
 # we use both C and C++, so advertize C++
 language: cpp
 cache: ccache
-dist: trusty
-compiler:
-  - gcc
</pre>
<p>If this is removed, which compiler is being used for the <code>env</code> part?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2067#pullrequestreview-232169736">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZYGKPW64RQ6HB4ZPLPTHKFXANCNFSM4GSODDDQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3RME3B2IOJVX4PFK3PTHKFXA5CNFSM4GSODDD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBXLKCCA.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #2067"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2067#pullrequestreview-232169736"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2067#pullrequestreview-232169736",
"url": "https://github.com/geany/geany/pull/2067#pullrequestreview-232169736",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>