<p><b>@elextr</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/436#discussion_r279191981">src/vte.c</a>:</p>
<pre style='color:#555'>> @@ -675,6 +682,45 @@ const gchar *vte_get_working_directory(void)
                                g_free(cwd);
                        }
                }
+               else
+               {
+                       gint status = 0;
+                       gchar *stdout = NULL;
+                       gchar *pid_str = g_strdup_printf("%d", pid);
+                       gchar *argv[] = {"lsof", "-a", "-d", "cwd", "-F", "n", "-p", pid_str, NULL};
</pre>
<p>Note the <code>exec</code> family of system calls takes <code>char* const argv[]</code> so <code>g_spawn</code> is looser than needed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/436#discussion_r279191981">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4BRR3LGTAWGOLBUZLPSWIBJANCNFSM4A5JNSKQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZOG6YEML6DPSUNX4DPSWIBJANCNFSM4A5JNSKQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr commented on #436"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/436#discussion_r279191981"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/436#discussion_r279191981",
"url": "https://github.com/geany/geany/pull/436#discussion_r279191981",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>