<p>You know what?  I actually changed my mind thinking about this lately, and now agree the best way to go is probably just use whatever upstream does.  The goal is to use upstream as if it was a library, and actually target making it one that we could simply use.  And one of the prominent CTags features is custom parser definitions (even more so with recent uctags additions), and even though we don't support this in Geany yet, it probably shouldn't be stripped from a libuctags.</p>
<p>So, I'll withdraw my "please, no duplicated regex libraries" argument.  I'm still not in love with it, but now think it's probably the lesser of the evils (esp. if we can use the OS' regex one in most setups -- but the odd Windows kid).<br>
I have no idea how easy it'll be to get the regex parsing code in, though.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/2119#issuecomment-480483522">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ98Y8K2Mr5NJo8I9U0k35hIr0nS3ks5veFF9gaJpZM4cgAf5">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ1BqPSfVnESZkqXT5bs-wpAqMtOvks5veFF9gaJpZM4cgAf5.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #2119: You know what?  I actually changed my mind thinking about this lately, and now agree the best way to go is probably just use whatever upstream does.  The goal is to use upstream as if it was a library, and actually target making it one that we could simply use.  And one of the prominent CTags features is custom parser definitions (even more so with recent uctags additions), and even though we don't support this in Geany yet, it probably shouldn't be stripped from a libuctags.\r\n\r\nSo, I'll withdraw my \"please, no duplicated regex libraries\" argument.  I'm still not in love with it, but now think it's probably the lesser of the evils (esp. if we can use the OS' regex one in most setups -- but the odd Windows kid).\r\nI have no idea how easy it'll be to get the regex parsing code in, though."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/2119#issuecomment-480483522"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/issues/2119#issuecomment-480483522",
"url": "https://github.com/geany/geany/issues/2119#issuecomment-480483522",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>