<blockquote>
<p>If by "where" you mean "when" then I thought settings are now pretty much always saved when they are changed</p>
</blockquote>
<p>I mean this PR only adds more places where configuration is saved (compared to only on prefs dialog applied, plugin manager closed, app closed, etc.) but it's still not comprehensive. In a perfect world there would be an interface/abstraction for the config system that whenever any setting is changed, a save is automatically queued, similar to something like Xfconf or GSettings or such. To give an example, even after this PR, if you used <code>View->Show Indentation Guides</code>, that setting still wouldn't be saved until one of the arbitrary places which saves the configuration is hit.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2114#issuecomment-477829819">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxroX0HJ08TDdkB3S0sNzAjdmALrks5vbWuOgaJpZM4cQ_4i">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ7nnRnNROhVuq02n2b__Gameay5Pks5vbWuOgaJpZM4cQ_4i.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #2114: \u003e If by \"where\" you mean \"when\" then I thought settings are now pretty much always saved when they are changed\r\n\r\nI mean this PR only adds more places where configuration is saved (compared to only on prefs dialog applied, plugin manager closed, app closed, etc.) but it's still not comprehensive. In a perfect world there would be an interface/abstraction for the config system that whenever any setting is changed, a save is automatically queued, similar to something like Xfconf or GSettings or such. To give an example, even after this PR, if you used `View-\u003eShow Indentation Guides`, that setting still wouldn't be saved until one of the arbitrary places which saves the configuration is hit."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2114#issuecomment-477829819"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2114#issuecomment-477829819",
"url": "https://github.com/geany/geany/pull/2114#issuecomment-477829819",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>