<p>This is not really the right fix, <code>g_return_*if_fail()</code> is supposed to catch programming error, to check the contract between the caller and the callee.  Admittedly here the values are accessed before the contract is checked, which is probably worth fixing, but the bug itself is that these functions get called with values they are not supposed to.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/827#issuecomment-465583018">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8QZDagkfQsJEYMocAaoLXyAyAIIks5vPVNqgaJpZM4bBgjE">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJz9bnipIHa1RYpqbR4Q-AFAjz10oks5vPVNqgaJpZM4bBgjE.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #827: This is not really the right fix, `g_return_*if_fail()` is supposed to catch programming error, to check the contract between the caller and the callee.  Admittedly here the values are accessed before the contract is checked, which is probably worth fixing, but the bug itself is that these functions get called with values they are not supposed to."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/827#issuecomment-465583018"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/827#issuecomment-465583018",
"url": "https://github.com/geany/geany-plugins/pull/827#issuecomment-465583018",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>