<p><b>@b4n</b> requested changes on this pull request.</p>

<p>Otherwise looks good, although I didn't test it yet (will try to do tomorrow).</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/821#discussion_r256182323">git-changebar/src/gcb-plugin.c</a>:</p>
<pre style='color:#555'>> @@ -45,6 +45,10 @@
                     new_buffer, new_len, new_as_path, options, \
                     file_cb, hunk_cb, line_cb, payload)
 #endif
+#if LIBGIT2_VER_MAJOR == 0 && LIBGIT2_VER_MINOR < 28
</pre>
<p>Please use the same kind of checks used above, i.e.</p>
⬇️ Suggested change
<pre style="color: #555">-#if LIBGIT2_VER_MAJOR == 0 && LIBGIT2_VER_MINOR < 28
+#if ! defined (LIBGIT2_SOVERSION) || LIBGIT2_SOVERSION < 28
</pre>

<p>it's consistent, and properly handles versions before those macros were introduced.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/821#discussion_r256182684">git-changebar/src/gcb-plugin.c</a>:</p>
<pre style='color:#555'>> @@ -45,6 +45,10 @@
                     new_buffer, new_len, new_as_path, options, \
                     file_cb, hunk_cb, line_cb, payload)
 #endif
+#if LIBGIT2_VER_MAJOR == 0 && LIBGIT2_VER_MINOR < 28
+#define git_buf_dispose(x) git_buf_free(x)
+#define git_error_last() giterr_last()
</pre>
<p>Insert a space between <code>#</code> and <code>define</code> as indentation showing it's nested in the <code>#if</code> (as the similar ones above)</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/821#discussion_r256183643">git-changebar/src/gcb-plugin.c</a>:</p>
<pre style='color:#555'>> @@ -45,6 +45,10 @@
                     new_buffer, new_len, new_as_path, options, \
                     file_cb, hunk_cb, line_cb, payload)
 #endif
+#if LIBGIT2_VER_MAJOR == 0 && LIBGIT2_VER_MINOR < 28
+#define git_buf_dispose(x) git_buf_free(x)
+#define git_error_last() giterr_last()
</pre>
<p>there's also no need to include arguments as they are identical, it would be enough to do</p>
<div class="highlight highlight-source-c"><pre># <span class="pl-k">define</span> <span class="pl-en">git_buf_dispose</span>  git_buf_free
# <span class="pl-k">define</span> <span class="pl-en">git_error_last</span>   giterr_last</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/821#pullrequestreview-202951728">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ2NHAcZgjfBP6wAqYNqT-4fAPj1Iks5vM0gmgaJpZM4a1b6z">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ24wourorwK2WhAOEDy0NG2aYzWZks5vM0gmgaJpZM4a1b6z.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #821"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/821#pullrequestreview-202951728"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/821#pullrequestreview-202951728",
"url": "https://github.com/geany/geany-plugins/pull/821#pullrequestreview-202951728",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>