<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=10910745" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/danpla">@danpla</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=181177" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/codebrainz">@codebrainz</a> totally agree with both of you, special comment handling is language specific and shouldn't be in Geany core, but it is, and has been for ages, so unless "somebody"[1] wants to make a pull request removing it to a plugin[2] then this is just a change to existing functionality.</p>
<p>And since its a change to existing functionality, which already has a setting in prefs, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=10910745" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/danpla">@danpla</a> has just suggested adding a sub-setting to that existing setting.  Although that prefs page is busy, there is space for another line (at least on my font size).  So it seems a reasonable solution.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=10910745" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/danpla">@danpla</a> havn't actually looked at your code</p>
<p>[1] "somebody" in quotes is an olde time convention in Geany meaning "somebody, not necessarily you, but definitely won't be me", blame <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=617017" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> <g-emoji class="g-emoji" alias="grin" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f601.png">😁</g-emoji></p>
<p>[2] an alternative would of course be to make the in-core functionality language agnostic by using the existing and perhaps additional comment settings in filetype files, but "somebody" has to do it</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2082#issuecomment-461627581">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwNNGunLh_h-ZXiANJwuY2G8Soadks5vLLNJgaJpZM4alToK">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJw7XUdgTOIyblDdM0XoDJa4OP_Enks5vLLNJgaJpZM4alToK.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #2082: @danpla @codebrainz totally agree with both of you, special comment handling is language specific and shouldn't be in Geany core, but it is, and has been for ages, so unless \"somebody\"[1] wants to make a pull request removing it to a plugin[2] then this is just a change to existing functionality.\r\n\r\nAnd since its a change to existing functionality, which already has a setting in prefs, @danpla has just suggested adding a sub-setting to that existing setting.  Although that prefs page is busy, there is space for another line (at least on my font size).  So it seems a reasonable solution.\r\n\r\n@danpla havn't actually looked at your code\r\n\r\n[1] \"somebody\" in quotes is an olde time convention in Geany meaning \"somebody, not necessarily you, but definitely won't be me\", blame @eht16 :grin:\r\n\r\n[2] an alternative would of course be to make the in-core functionality language agnostic by using the existing and perhaps additional comment settings in filetype files, but \"somebody\" has to do it\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2082#issuecomment-461627581"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2082#issuecomment-461627581",
"url": "https://github.com/geany/geany/pull/2082#issuecomment-461627581",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>