<p>I don't know, I have mixed opinion on this.  Ideally the workflow would be authors use <code>git commit --fixup</code> for fixup commits, and at some point when everything was approved, somebody does <code>git rebase -i --autosquash base</code>.  Who's that somebody is unfortunately annoying because</p>
<ul>
<li>if it's the PR author, the merger has to re-check this didn't introduce changes</li>
<li>if it's the merger, GitHub doesn't provide a way of closing the PR (at least not that I know of from the CLI side).</li>
</ul>
<p>As I won't use the GitHub UI for merging, and would rather see PRs as "merged" than "closed", I still kinda like having the author to the squashing and just diff the before/after.<br>
Otherwise, letting the merger do it is probably best, unless the PR author is a power user.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2059#issuecomment-455577943">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8Bn3XhMYkpq0BzblTJhSGXyRg5fks5vEePLgaJpZM4aHHkR">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ7SlhpawyYfrhN7LSsIqEhlRQYh3ks5vEePLgaJpZM4aHHkR.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #2059: I don't know, I have mixed opinion on this.  Ideally the workflow would be authors use `git commit --fixup` for fixup commits, and at some point when everything was approved, somebody does `git rebase -i --autosquash base`.  Who's that somebody is unfortunately annoying because\r\n* if it's the PR author, the merger has to re-check this didn't introduce changes\r\n* if it's the merger, GitHub doesn't provide a way of closing the PR (at least not that I know of from the CLI side).\r\n\r\nAs I won't use the GitHub UI for merging, and would rather see PRs as \"merged\" than \"closed\", I still kinda like having the author to the squashing and just diff the before/after.\r\nOtherwise, letting the merger do it is probably best, unless the PR author is a power user."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2059#issuecomment-455577943"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2059#issuecomment-455577943",
"url": "https://github.com/geany/geany/pull/2059#issuecomment-455577943",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>