<blockquote>
<p>So can't we just make it a shallow shim over glib instead of including the ctags one?</p>
</blockquote>
<p>Probably we could make some wrapper around it but there are minor semantic differences between the APIs which are easy to miss and which we probably won't notice in the future when something in upstream uctags changes and we just grab the sources from there.</p>
<p>All the parsers upstream from the "parsers" directory are non-regex ones and the regex ones are only those from</p>
<p><a href="https://github.com/universal-ctags/ctags/tree/master/optlib">https://github.com/universal-ctags/ctags/tree/master/optlib</a></p>
<p>but none of the languages seem too interesting for Geany (we have a hand-written markdown parser). So we won't miss much from the upstream by killing the regex parser support. So the only problem are Actionscript and Cobol parsers. As I said, personally, I would drop them. But the second best solution would be rewriting them as non-regex parsers (but preferably not by me - <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> you said something like it would be fun rewriting those - I would really hate myself for stealing the fun from you :-)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2018#issuecomment-454124079">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ65O1iRVk-wN-hc7v8Z3KX1QW6l7ks5vDNXfgaJpZM4ZXOnd">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ-o3qikghLkBt2agcqsBljDri9_Hks5vDNXfgaJpZM4ZXOnd.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #2018: \u003e So can't we just make it a shallow shim over glib instead of including the ctags one?\r\n\r\nProbably we could make some wrapper around it but there are minor semantic differences between the APIs which are easy to miss and which we probably won't notice in the future when something in upstream uctags changes and we just grab the sources from there.\r\n\r\nAll the parsers upstream from the \"parsers\" directory are non-regex ones and the regex ones are only those from\r\n\r\nhttps://github.com/universal-ctags/ctags/tree/master/optlib\r\n\r\nbut none of the languages seem too interesting for Geany (we have a hand-written markdown parser). So we won't miss much from the upstream by killing the regex parser support. So the only problem are Actionscript and Cobol parsers. As I said, personally, I would drop them. But the second best solution would be rewriting them as non-regex parsers (but preferably not by me - @b4n you said something like it would be fun rewriting those - I would really hate myself for stealing the fun from you :-)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2018#issuecomment-454124079"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2018#issuecomment-454124079",
"url": "https://github.com/geany/geany/pull/2018#issuecomment-454124079",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>