<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2036#discussion_r245611505">src/symbols.c</a>:</p>
<pre style='color:#555'>> @@ -908,6 +908,18 @@ static gchar *get_symbol_tooltip(GeanyDocument *doc, const TMTag *tag)
 {
        gchar *utf8_name = editor_get_calltip_text(doc->editor, tag);
 
+       if (!utf8_name && tag->var_type &&
+               tag->type & (tm_tag_member_t | tm_tag_variable_t | tm_tag_externvar_t))
</pre>
<p>Is the type check guarding against actual issues, or is it just being careful?  I can imagine it might be a problem with typedefs, but it might erroneously omit <code>tm_tag_field_t</code> (not 100% sure what that is, but it's used by several parsers, and I believe for Vala it's variable members).<br>
Not a blocker though, we can amend this as needed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2036#pullrequestreview-189754329">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJytCa3oT1xPnpeVwMhKZNJnRhav4ks5vAyOZgaJpZM4ZosQB">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ4LdAVk-dtYpWZOWcbqonGGWhN92ks5vAyOZgaJpZM4ZosQB.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #2036"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2036#pullrequestreview-189754329"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2036#pullrequestreview-189754329",
"url": "https://github.com/geany/geany/pull/2036#pullrequestreview-189754329",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>