<p>To be clear, I'm not really opposed to using Github to make edits+PRs[0], I just wanted to see how it worked because I hadn't tried it before and it seemed odd that Github was messing with the main repo in order to make PRs. Now I realize it lets people with push access edit+PR directly on the main repo and doesn't force you to do it on your own fork, which is the only part I don't like much.</p>
<p>[0]: for small text/documentation changes. I do think PRers should at least test code changes themselves on their machine as a minimum bar though (which <em>was</em> done last time), at which point it's no faster re-doing the changes in the online editor instead of just pushing to your fork and making a PR. From this point of view, the online editor isn't terribly useful, IMO.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2035#issuecomment-451311847">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwFFw4nTyQ1T8DjTz1TC2RWEaIJnks5u_pMWgaJpZM4ZnctU">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ4S1MBD9pqBUuzM12iAAma8Rvh3aks5u_pMWgaJpZM4ZnctU.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #2035: To be clear, I'm not really opposed to using Github to make edits+PRs[0], I just wanted to see how it worked because I hadn't tried it before and it seemed odd that Github was messing with the main repo in order to make PRs. Now I realize it lets people with push access edit+PR directly on the main repo and doesn't force you to do it on your own fork, which is the only part I don't like much.\r\n\r\n[0]: for small text/documentation changes. I do think PRers should at least test code changes themselves on their machine as a minimum bar though (which _was_ done last time), at which point it's no faster re-doing the changes in the online editor instead of just pushing to your fork and making a PR. From this point of view, the online editor isn't terribly useful, IMO."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2035#issuecomment-451311847"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2035#issuecomment-451311847",
"url": "https://github.com/geany/geany/pull/2035#issuecomment-451311847",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>