<blockquote>
<p>Hence my question, why are you doing something different, why not just put the original back since its in upstream?</p>
<p>Isn't the purpose of this whole exercise to sync with upstream?</p>
</blockquote>
<p>It is, but I'm not sure upstream itself shouldn't be changed.  The most important reason why this is a problem is that with this behavior the parser output is semantically different from other parsers -- not to mention that it's then harder to distinguish children of identically-named sections.</p>
<p>But yeah, the PR here is just one solution, and we can and probably should use upstream's, changed or not.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2019#issuecomment-448207766">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-oMbbtQ1tFo4kyNF3n04ocVMaZsks5u6OKvgaJpZM4ZXxvS">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ8Gk5S03Vuw3qmCACM4yvOscsovhks5u6OKvgaJpZM4ZXxvS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #2019: \u003e Hence my question, why are you doing something different, why not just put the original back since its in upstream?\r\n\u003e\r\n\u003eIsn't the purpose of this whole exercise to sync with upstream?\r\n\r\nIt is, but I'm not sure upstream itself shouldn't be changed.  The most important reason why this is a problem is that with this behavior the parser output is semantically different from other parsers -- not to mention that it's then harder to distinguish children of identically-named sections.\r\n\r\nBut yeah, the PR here is just one solution, and we can and probably should use upstream's, changed or not. "}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2019#issuecomment-448207766"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2019#issuecomment-448207766",
"url": "https://github.com/geany/geany/pull/2019#issuecomment-448207766",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>