<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a>: Yes, I reviewed this. I have to admit that I never wrote a debugger myself. But the things changed here only apply to the GUI, not to the debugger related internals.</p>
<p>I tested the following:</p>
<ul>
<li>building under Ubuntu with GTK2 and 3</li>
<li>simple test under Ubuntu with GTK2 and 3: run a program in the debugger, have some breakpoints. Inspect some variables. I clicked some icons and dialogs, nothing seems to be broken.</li>
<li>I did not test the GUI extensively (that means, I did <strong>not</strong> make a checkpoint list of all debugger related icons and menus and tested each of it)</li>
<li>I did not test or build under Windows or Mac</li>
<li>I had a look at the GTK API calls and the GTK versions for which they are supported and suggested changes (see the review for details)</li>
<li>Changes were applied and I re-tested and re-viewed again</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/791#issuecomment-444179781">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxBy3bcGs_DMZ5mO1dozHBGBLqwIks5u1q0HgaJpZM4YrdeP">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ796BO9m80Q9bIAChIhvLxLdLQLlks5u1q0HgaJpZM4YrdeP.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@LarsGit223 in #791: @elextr, @b4n: Yes, I reviewed this. I have to admit that I never wrote a debugger myself. But the things changed here only apply to the GUI, not to the debugger related internals.\r\n\r\nI tested the following:\r\n- building under Ubuntu with GTK2 and 3\r\n- simple test under Ubuntu with GTK2 and 3: run a program in the debugger, have some breakpoints. Inspect some variables. I clicked some icons and dialogs, nothing seems to be broken.\r\n- I did not test the GUI extensively (that means, I did **not** make a checkpoint list of all debugger related icons and menus and tested each of it)\r\n- I did not test or build under Windows or Mac\r\n- I had a look at the GTK API calls and the GTK versions for which they are supported and suggested changes (see the review for details)\r\n- Changes were applied and I re-tested and re-viewed again"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/791#issuecomment-444179781"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/791#issuecomment-444179781",
"url": "https://github.com/geany/geany-plugins/pull/791#issuecomment-444179781",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)",
"sections": [
{
"text": "",
"activityTitle": "**LarsGit223**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@LarsGit223",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 791,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"pullRequestId\": 791\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/791#issuecomment-444179781"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 414046095\n}"
}
],
"themeColor": "26292E"
}
]</script>