<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> , <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a>: I wouldn't mind changing this because IMHO I would at least call it unusual or "kind of ugly" to not have sizeof with parentheses surrounding it.</p>
<p>But another question: what is the sense behind the comparsion in</p>
<pre><code>pointer_size = sizeof(void *) > sizeof &memory_init ? sizeof(void *) :
sizeof &memory_init;
</code></pre>
<p>Can the size of that pointers ever be not equal??? <g-emoji class="g-emoji" alias="confused" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f615.png">😕</g-emoji></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/issues/794#issuecomment-442944735">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-TicuH6aG_yEpMZUybfodFGzLOlks5u0CmHgaJpZM4Y5E1j">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ05WsiRsAaNoMqXeKqIsoo2UPp5lks5u0CmHgaJpZM4Y5E1j.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@LarsGit223 in #794: @elextr , @b4n: I wouldn't mind changing this because IMHO I would at least call it unusual or \"kind of ugly\" to not have sizeof with parentheses surrounding it.\r\n\r\nBut another question: what is the sense behind the comparsion in\r\n```\r\npointer_size = sizeof(void *) \u003e sizeof \u0026memory_init ? sizeof(void *) :\r\nsizeof \u0026memory_init;\r\n```\r\nCan the size of that pointers ever be not equal??? :confused:"}],"action":{"name":"View Issue","url":"https://github.com/geany/geany-plugins/issues/794#issuecomment-442944735"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/issues/794#issuecomment-442944735",
"url": "https://github.com/geany/geany-plugins/issues/794#issuecomment-442944735",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany-plugins] Scope breaks nightly with gcc 8 (#794)",
"sections": [
{
"text": "",
"activityTitle": "**LarsGit223**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@LarsGit223",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 794,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 794\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/issues/794#issuecomment-442944735"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 417615203\n}"
}
],
"themeColor": "26292E"
}
]</script>