<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1445#discussion_r236049449">src/utils.c</a>:</p>
<pre style='color:#555'>> + * @return @transfer{full} A newly-allocated array of transformed paths strings, terminated by
+            @c NULL. Use @c g_strfreev() to free it.
+ *
+ * @since 1.31 (API 232)
+ */
+GEANY_API_SYMBOL
+gchar **utils_strv_shorten_file_list(gchar **file_names, gssize num)
+{
+       gsize i;
+       gchar *prefix, *substring, *lcs;
+       gchar *start, *end;
+       gchar **names;
+       gsize prefix_len, lcs_len;
+
+       /* We don't dereference file_names if num == 0. */
+       g_return_val_if_fail(num != 0 && file_names == NULL, NULL);
</pre>
<p>This should be <code>num == 0 || file_names != NULL</code>, as it's basically an assertion, and should list conditions expected to pass.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1445#pullrequestreview-178057950">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzzmaFHjcT9HRz6qBmywH6cRKATdks5uyYpvgaJpZM4MnYrc">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ_DDVZHpn8bsrYNFTs3cIJqxdKrEks5uyYpvgaJpZM4MnYrc.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1445"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1445#pullrequestreview-178057950"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1445#pullrequestreview-178057950",
"url": "https://github.com/geany/geany/pull/1445#pullrequestreview-178057950",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@b4n commented on 1445",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1445#pullrequestreview-178057950"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 211651292\n}"
}
],
"themeColor": "26292E"
}
]</script>