<p>I also get all the tree folding up when right clicking.</p>
<p>To be clear, this is unacceptable, I can't close a file without losing my fold state.</p>
<p>This should be merged as is.</p>
<p>This PR has a history of more bugs being found each time its "ready" probably because <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=564520" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> has only had the chance to work on it intermittently, so although I like the intent I, don't think the implementation is suitable for last minute merging.</p>
<p>It should be held over and merged after 1.34 (and after its fixed) so any further bugs can be worked out before a release.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1813#issuecomment-441404187">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8Bbn4BNn556rnohJIxckfLGjsj5ks5uydpSgaJpZM4SyLKn">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ8nXsePsQ9XuZf-3Ij5713TYb56jks5uydpSgaJpZM4SyLKn.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1813: I also get all the tree folding up when right clicking.\r\n\r\nTo be clear, this is unacceptable, I can't close a file without losing my fold state.  \r\n\r\nThis should be merged as is.\r\n\r\nThis PR has a history of more bugs being found each time its \"ready\" probably because @kugel- has only had the chance to work on it intermittently, so although I like the intent I, don't think the implementation is suitable for last minute merging.  \r\n\r\nIt should be held over and merged after 1.34 (and after its fixed) so any further bugs can be worked out before a release."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1813#issuecomment-441404187"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1813#issuecomment-441404187",
"url": "https://github.com/geany/geany/pull/1813#issuecomment-441404187",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] Rpg sidebar tree (see #259) (#1813)",
"sections": [
{
"text": "",
"activityTitle": "**elextr**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@elextr",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1813,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1813\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1813#issuecomment-441404187"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 315142823\n}"
}
],
"themeColor": "26292E"
}
]</script>