<blockquote>
<p>Also, regarding Vte I wanted to prevent that the utils lib always depends on Vte even if no plugin is enabled which uses it. That's why there is this "cross-reference" in the makefiles. I didn't know a better way to do it. If there is a cleaner way for archiving this then I am open for suggestions.</p>
</blockquote>
<p>Look at <a class="commit-link" href="https://github.com/geany/geany-plugins/commit/347a0c15fa1d67d3830c3e3537c319d43c0b157e"><tt>347a0c1</tt></a> :)</p>
<blockquote>
<p>Vte compatibility code might not be used often but there are definitely some plugins which still need to be ported to Gtk3. […]</p>
</blockquote>
<p>I'm not saying that it's a bad thing to have VTE compatibility code in that utils lib, but that in the current state it doesn't seem super friendly for other users to me.  But indeed it can be improved and made to fit in the future as consumers grow.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/787#issuecomment-436897080">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3vtEqVf5RuYhs0MXTJvxxx7AUgVks5us9ttgaJpZM4X_BPU">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ3VhyTHwBWnaBdSb_9IhixQ5nIKeks5us9ttgaJpZM4X_BPU.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #787: \u003e Also, regarding Vte I wanted to prevent that the utils lib always depends on Vte even if no plugin is enabled which uses it. That's why there is this \"cross-reference\" in the makefiles. I didn't know a better way to do it. If there is a cleaner way for archiving this then I am open for suggestions.\r\n\r\nLook at https://github.com/geany/geany-plugins/pull/787/commits/347a0c15fa1d67d3830c3e3537c319d43c0b157e :)\r\n\r\n\u003e Vte compatibility code might not be used often but there are definitely some plugins which still need to be ported to Gtk3. […]\r\n\r\nI'm not saying that it's a bad thing to have VTE compatibility code in that utils lib, but that in the current state it doesn't seem super friendly for other users to me.  But indeed it can be improved and made to fit in the future as consumers grow."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/787#issuecomment-436897080"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/787#issuecomment-436897080",
"url": "https://github.com/geany/geany-plugins/pull/787#issuecomment-436897080",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany-plugins] Scope: fix Automake conditional when building for Windows (#787)",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 787,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"pullRequestId\": 787\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/787#issuecomment-436897080"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402396116\n}"
}
],
"themeColor": "26292E"
}
]</script>