<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> I do not understand 'This change will also fail to de-dup paths that are linked to the same file'<br>
I thought, the old code did not do that either, but just hashed it into the same bucket.</p>
<p>Diffs looked like <a href="http://rb.zq1.de/compare.factory-20180730/glfw-compare.out" rel="nofollow">http://rb.zq1.de/compare.factory-20180730/glfw-compare.out</a></p>
<div class="highlight highlight-source-diff"><pre><span class="pl-md">--- old//usr/share/geany/tags/glfw.c.tags   2017-02-12 12:00:00.000000000 +0000</span>
<span class="pl-mi1">+++ new//usr/share/geany/tags/glfw.c.tags  2017-02-12 12:00:00.000000000 +0000</span>
<span class="pl-mdr">@@ -525,23 +525,23 @@</span>
 DN_MULTISHOTÌ65536Ö0
 DN_RENAMEÌ65536Ö0
 DTTOIFÌ131072Í(dirtype)Ö0
<span class="pl-md"><span class="pl-md">-</span>DT_BLKÌ4Îanon_enum_26Ö0</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>DT_BLKÌ4Îanon_enum_29Ö0</span>
 DT_BLKÌ65536Ö0
<span class="pl-md"><span class="pl-md">-</span>DT_CHRÌ4Îanon_enum_26Ö0</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>DT_CHRÌ4Îanon_enum_29Ö0</span>
 DT_CHRÌ65536Ö0
 [...]
<span class="pl-md"><span class="pl-md">-</span>KHR_xlib_surfaceÌ64Î_GLFWlibrary::anon_struct_20Ö0ÏGLFWbool</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>KHR_xlib_surfaceÌ64Î_GLFWlibrary::anon_struct_4Ö0ÏGLFWbool</span></pre></div>
<p>So is there any reason against merging this change?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1989#issuecomment-436594032">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJyvKWM1YPj7-4y2TOFeoB5d0eJJEks5ussRHgaJpZM4YQS08">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJynkVOUtgdb4OVFOe3tgTJ_C1JD4ks5ussRHgaJpZM4YQS08.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bmwiedemann in #1989: @elextr I do not understand 'This change will also fail to de-dup paths that are linked to the same file' \r\nI thought, the old code did not do that either, but just hashed it into the same bucket.\r\n\r\nDiffs looked like http://rb.zq1.de/compare.factory-20180730/glfw-compare.out\r\n```diff\r\n--- old//usr/share/geany/tags/glfw.c.tags\t2017-02-12 12:00:00.000000000 +0000\r\n+++ new//usr/share/geany/tags/glfw.c.tags\t2017-02-12 12:00:00.000000000 +0000\r\n@@ -525,23 +525,23 @@\r\n DN_MULTISHOTÌ65536Ö0\r\n DN_RENAMEÌ65536Ö0\r\n DTTOIFÌ131072Í(dirtype)Ö0\r\n-DT_BLKÌ4Îanon_enum_26Ö0\r\n+DT_BLKÌ4Îanon_enum_29Ö0\r\n DT_BLKÌ65536Ö0\r\n-DT_CHRÌ4Îanon_enum_26Ö0\r\n+DT_CHRÌ4Îanon_enum_29Ö0\r\n DT_CHRÌ65536Ö0\r\n [...]\r\n-KHR_xlib_surfaceÌ64Î_GLFWlibrary::anon_struct_20Ö0ÏGLFWbool\r\n+KHR_xlib_surfaceÌ64Î_GLFWlibrary::anon_struct_4Ö0ÏGLFWbool\r\n```\r\n\r\nSo is there any reason against merging this change?"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1989#issuecomment-436594032"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1989#issuecomment-436594032",
"url": "https://github.com/geany/geany/pull/1989#issuecomment-436594032",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] Make geany -g tags output reproducible (#1989)",
"sections": [
{
"text": "",
"activityTitle": "**Bernhard M. Wiedemann**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bmwiedemann",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1989,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1989\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1989#issuecomment-436594032"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 406924604\n}"
}
],
"themeColor": "26292E"
}
]</script>