<blockquote>
<p>So using inode as the hash is just a slow way of making a hash of a file path.</p>
</blockquote>
<p>Well, the inode gets a goodish hash, but the equal check makes it worse than a string hash and comparison on the file path yeah.<br>
If really the inode thing was useful, it should be used as the key directly rather than a bad convoluted hash that's guaranteed to have a worse <code>stat()</code> call count anyway.</p>
<blockquote>
<p>Yeah, since 2.40 <code>g_hash_table_insert()</code> returns if it inserted or not, so the filename could be added to the list on the fly.  But Glib 2.40 didn't exist back when this was originally written.</p>
</blockquote>
<p>The code <a href="https://github.com/geany/geany/blob/97547edb52e34b8f78f44a13548a0fb55baf1a44/src/tagmanager/tm_workspace.c#L534">already checks if the hash table contains the element before inserting it</a>, so it should be OK no matter which version is used.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1989#issuecomment-436781540">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzUL0GCNjzcJMwpx3Mvd1dAm9i1Iks5us07BgaJpZM4YQS08">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ8pFYyEZDlidA0rI2Mlz6ZU1CIAfks5us07BgaJpZM4YQS08.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1989: \u003e So using inode as the hash is just a slow way of making a hash of a file path.\r\n\r\nWell, the inode gets a goodish hash, but the equal check makes it worse than a string hash and comparison on the file path yeah.\r\nIf really the inode thing was useful, it should be used as the key directly rather than a bad convoluted hash that's guaranteed to have a worse `stat()` call count anyway.\r\n\r\n\u003e Yeah, since 2.40 `g_hash_table_insert()` returns if it inserted or not, so the filename could be added to the list on the fly.  But Glib 2.40 didn't exist back when this was originally written.\r\n\r\nThe code [already checks if the hash table contains the element before inserting it](https://github.com/geany/geany/blob/97547edb52e34b8f78f44a13548a0fb55baf1a44/src/tagmanager/tm_workspace.c#L534), so it should be OK no matter which version is used."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1989#issuecomment-436781540"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1989#issuecomment-436781540",
"url": "https://github.com/geany/geany/pull/1989#issuecomment-436781540",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] Make geany -g tags output reproducible (#1989)",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1989,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1989\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1989#issuecomment-436781540"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 406924604\n}"
}
],
"themeColor": "26292E"
}
]</script>