<blockquote>
<p>All look very good. Most of those are things I should have considered myself, sorry for that.</p>
</blockquote>
<p>Great, good to hear!</p>
<blockquote>
<p>Regarding empty directories, yes, this makes the tree a bit more crowded. It would be possible to haved them hidden and show them only when their parent is selected, maybe with a dimmed icon, but I thought it may be a little bit confusing and, more important, it was too complex for the time I had available.</p>
</blockquote>
<p>Yeah, I think it's not worth it. I was thinking about some config option to disable showing empty directories (which would kind of kill the "create directory" feature for users who would enable it) but I think I'll wait with this and see if users are complaining about it or just don't care.</p>
<p>I've created <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="370627652" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany-plugins/issues/783" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany-plugins/pull/783/hovercard" href="https://github.com/geany/geany-plugins/pull/783">#783</a> with the extra patches and will close this pull request. Thanks a lot for contributing the code!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ_ByQU1qb7DcQV0dX3NXoLNCX_5Aks5uledwgaJpZM4V4W0C">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ5YzQAB7J8Hr8N3rttyNxCW6_Mg5ks5uledwgaJpZM4V4W0C.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #767: \u003e All look very good. Most of those are things I should have considered myself, sorry for that.\r\n\r\nGreat, good to hear!\r\n\r\n\u003e Regarding empty directories, yes, this makes the tree a bit more crowded. It would be possible to haved them hidden and show them only when their parent is selected, maybe with a dimmed icon, but I thought it may be a little bit confusing and, more important, it was too complex for the time I had available.\r\n\r\nYeah, I think it's not worth it. I was thinking about some config option to disable showing empty directories (which would kind of kill the \"create directory\" feature for users who would enable it) but I think I'll wait with this and see if users are complaining about it or just don't care.\r\n\r\nI've created #783 with the extra patches and will close this pull request. Thanks a lot for contributing the code!"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332",
"url": "https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany-plugins] Add file operations to Project Organizer. (#767)",
"sections": [
{
"text": "",
"activityTitle": "**Jiří Techet**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@techee",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 767,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 367095042\n}"
}
],
"themeColor": "26292E"
}
]</script>