<p><a class="user-mention" data-hovercard-user-id="811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> no, I just got sidetracked by life.</p>
<p><a class="user-mention" data-hovercard-user-id="6333198" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Skif-off">@Skif-off</a> while in practice it might be ok-ish to just drop the messages and modify those users, it's not really a good thing to rely on because we can't be sure we caught all cases (what about unknown third party plugins?), and is more generally not a safe approach to compatibility break where the safe path is usually the best one.  And here the "problem" it causes is that plugins have to be recompiled, which usually isn't much of a big deal.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1914#issuecomment-422169002">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3akGlV6Hw8eawcotezFDZMSBMRyks5ucA0QgaJpZM4VqtaY">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ_h7HlMaT7yWs4E0FFXPR1HspaJbks5ucA0QgaJpZM4VqtaY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1914: @elextr no, I just got sidetracked by life.\r\n\r\n@Skif-off while in practice it might be ok-ish to just drop the messages and modify those users, it's not really a good thing to rely on because we can't be sure we caught all cases (what about unknown third party plugins?), and is more generally not a safe approach to compatibility break where the safe path is usually the best one.  And here the \"problem\" it causes is that plugins have to be recompiled, which usually isn't much of a big deal."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1914#issuecomment-422169002"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1914#issuecomment-422169002",
"url": "https://github.com/geany/geany/pull/1914#issuecomment-422169002",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] Update Scintilla to version 3.10.0 (#1914)",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1914,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1914\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1914#issuecomment-422169002"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 363517592\n}"
}
],
"themeColor": "26292E"
}
]</script>