<p><b>@b4n</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1941#discussion_r214523800">HACKING</a>:</p>
<pre style='color:#555'>> @@ -341,6 +341,22 @@ Example::
     {
         ...
 
+Translation
+^^^^^^^^^^^
+
+Strings which are visible to geany users need to be translated and thus
+should be enclosed in ``_( )`` to have them being recognized by the GNU
+translation tools. Also spaces right after the first ``"`` of a string
+shall not be used as they will be cut of by the tools. This is a bad example::
</pre>
<p>No they won't be cut off.  If you're referring to my erroneous comment on <a class="user-mention" data-hovercard-user-id="6333198" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Skif-off">@Skif-off</a>'s PR recently, it was just me reading the diff the wrong way around and thinking he was removing the space instead of adding it.<br>
GNU GetText properly handle any C string, so where to place the space is not a concern for it to appear, it's a mere code style thing.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1941#discussion_r214523854">HACKING</a>:</p>
<pre style='color:#555'>> @@ -341,6 +341,22 @@ Example::
     {
         ...
 
+Translation
+^^^^^^^^^^^
+
+Strings which are visible to geany users need to be translated and thus
+should be enclosed in ``_( )`` to have them being recognized by the GNU
+translation tools. Also spaces right after the first ``"`` of a string
</pre>
<p><code>_()</code> is actually a function call, where <code>_</code> is an alias for <code>gettext</code>.  But yes, it's also used to recognize strings that need translating by the tools that read the source code for extracting strings for that purpose.<br>
But the formulation you chose is not perfect, it's not only for recognizing the string, but also to actually translate it for the program. <code>gettext()</code> (for which <code>_</code> is an alias) is returning the translated version of the passed-in string.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1941#discussion_r214523887">HACKING</a>:</p>
<pre style='color:#555'>> @@ -341,6 +341,22 @@ Example::
     {
         ...
 
+Translation
+^^^^^^^^^^^
+
+Strings which are visible to geany users need to be translated and thus
+should be enclosed in ``_( )`` to have them being recognized by the GNU
+translation tools. Also spaces right after the first ``"`` of a string
+shall not be used as they will be cut of by the tools. This is a bad example::
+
+    label = gtk_label_new (_("First sentence of a bad case example."
</pre>
<p>No space between the function name and the open parenthesis in Geany code style.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1941#discussion_r214523891">HACKING</a>:</p>
<pre style='color:#555'>> @@ -341,6 +341,22 @@ Example::
     {
         ...
 
+Translation
+^^^^^^^^^^^
+
+Strings which are visible to geany users need to be translated and thus
</pre>
<p>You should probably drop <code>geany</code> here (or at least capitalize it ;)).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1941#pullrequestreview-151604211">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ_pII9Am4yJKZDGNPOLuqc0hwbAzks5uWwKmgaJpZM4WWL75">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ1ViAVwc-fHsoySzTap-rdBuGg7dks5uWwKmgaJpZM4WWL75.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #1941"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1941#pullrequestreview-151604211"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1941#pullrequestreview-151604211",
"url": "https://github.com/geany/geany/pull/1941#pullrequestreview-151604211",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@b4n requested changes on 1941",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1941#pullrequestreview-151604211"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 374914809\n}"
}
],
"themeColor": "26292E"
}
]</script>