<blockquote>
<p>I tend to favor check-buttons over a combobox, as the latter will have to include a list for all possible combinations from (fixed-w, variable-w, normal); and checkbuttons are faster to see & access by the user.</p>
</blockquote>
<p>Yeah, in the case where multiple options can be selected then checkboxes is a better UI.</p>
<blockquote>
<p>GTK included in binaries is 2.24; because it uses the older fontSelectiionDialog, that means I may not even get to use the results of this work?</p>
</blockquote>
<p>It should be possible to do it to both versions, but possibly not the same code.  There are CERTAIN people <code></troll></code> who say you should <code>#ifdef</code> different code for GTK2 and GTK3, but I think its entirely up to the PR writer, so long as they don't break the other GTK version, extra functionality should be acceptable even if its for only one GTK version.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1928#issuecomment-417162018">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ75el7lhTucgFEh87eKtVXh2BoIEks5uV0NbgaJpZM4WGvIU">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ6XCnpfeyS7ySC1s0MZfag9I8mDfks5uV0NbgaJpZM4WGvIU.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1928: \u003e I tend to favor check-buttons over a combobox, as the latter will have to include a list for all possible combinations from (fixed-w, variable-w, normal); and checkbuttons are faster to see \u0026 access by the user.\r\n\r\nYeah, in the case where multiple options can be selected then checkboxes is a better UI.\r\n\r\n\u003e GTK included in binaries is 2.24; because it uses the older fontSelectiionDialog, that means I may not even get to use the results of this work?\r\n\r\nIt should be possible to do it to both versions, but possibly not the same code.  There are CERTAIN people `\u003c/troll\u003e` who say you should `#ifdef ` different code for GTK2 and GTK3, but I think its entirely up to the PR writer, so long as they don't break the other GTK version, extra functionality should be acceptable even if its for only one GTK version."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1928#issuecomment-417162018"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/issues/1928#issuecomment-417162018",
"url": "https://github.com/geany/geany/issues/1928#issuecomment-417162018",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] choose font: classify families into monospace/proportional (#1928)",
"sections": [
{
"text": "",
"activityTitle": "**elextr**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@elextr",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1928,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1928\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/issues/1928#issuecomment-417162018"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 370864660\n}"
}
],
"themeColor": "26292E"
}
]</script>