<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1752#discussion_r207922123">ctags/parsers/autoit.c</a>:</p>
<pre style='color:#555'>> +/*
+*   FUNCTION DEFINITIONS
+*/
+static void findAutoItTags (void)
+{
+       vString *name = vStringNew ();
+       const unsigned char *line;
+
+       while ((line = readLineFromInputFile ()) != NULL)
+       {
+               const unsigned char* p = line;
+               if (p [0] == '#')
+               {
+                       /* min. string "#region" > 7 */
+                       if ((p [1] == 'R' || p [1] == 'r') &&
+                               strlen ((const char *) p) > 8 &&
</pre>
<p>I still think it's irrelevant, because it's then an "optimization" (as the code after more correctly checks the syntax), but it only kicks in when the there is less than an extra 8 characters after the line starting with <code>f</code>. This is highly unlikely to result in any speed benefits (especially as you're checking the next characters for <code>unc[ \t]</code>), and is highly likely to let pass things that aren't a function anyway but just happen to be long enough.</p>
<p>In any case, unless profiling shows this is faster (I doubt it), the clearest/simplest thing should be used IMO, which IMO again, is dropping this check.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1752#discussion_r207922123">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ56xsGUmgu3f84EdmLnGEuQlh9YXks5uOFlFgaJpZM4RveNf">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ-NjGrpiXa3RNws0e-OjawycerWoks5uOFlFgaJpZM4RveNf.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1752"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1752#discussion_r207922123"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1752#discussion_r207922123",
"url": "https://github.com/geany/geany/pull/1752#discussion_r207922123",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@b4n commented on 1752",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1752#discussion_r207922123"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 297657183\n}"
}
],
"themeColor": "26292E"
}
]</script>