<p><a class="user-mention" data-hovercard-user-id="9417744" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tambeta">@tambeta</a> is <a class="commit-link" href="https://github.com/geany/geany/commit/225c4eeb1b40737ac447362435686c39b22bf3dc"><tt>225c4ee</tt></a> in upstream?  Improvements are good, but if they are not upstreamed one day someone will pull in the upstream parser and they will all be lost.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1820#issuecomment-397867369">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9-TlFT99L7maD3Clg0N2gS_guWzks5t9iYjgaJpZM4TKL22">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ0W-KvUaHY4MD7WIyvGPkXgYi4roks5t9iYjgaJpZM4TKL22.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany/pull/1820#issuecomment-397867369","url":"https://github.com/geany/geany/pull/1820#issuecomment-397867369","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1820: @tambeta is 225c4ee in upstream?  Improvements are good, but if they are not upstreamed one day someone will pull in the upstream parser and they will all be lost."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1820#issuecomment-397867369"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] ctags: fix Ruby parsing for block assigns (#1820)",
"sections": [
{
"text": "",
"activityTitle": "**elextr**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@elextr",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1820,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1820\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1820#issuecomment-397867369"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 321437110\n}"
}
],
"themeColor": "26292E"
}</script>