<p>Addresses relevant issues mentioned in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331557703" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/1876" href="https://github.com/geany/geany/issues/1876">#1876</a>. I didn't care about several "dead assignments", because they are initial values for variables, or make mirrors similar logic in the same function (like successive calls moving a pointer, I left the last one storing the move even if it's not (currently) used afterward), etc.</p>
<p><strong><g-emoji class="g-emoji" alias="warning" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/26a0.png">⚠️</g-emoji> WARNING <g-emoji class="g-emoji" alias="warning" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/26a0.png">⚠️</g-emoji></strong>  The Perl change should be checked by a Perl person, I don't really know if it actually makes sense to report this differently. Also, should be upstreamed if relevant. BTW, I can move this out of this PR.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1878'>https://github.com/geany/geany/pull/1878</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Report subroutine declarations as such</li>
  <li>Add a sanity check on the Save As callback</li>
  <li>Remove an unnecessary local variable</li>
  <li>Remove unused parameter</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1878/files#diff-0">ctags/parsers/perl.c</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1878/files#diff-1">src/dialogs.c</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1878/files#diff-2">src/editor.c</a>
    (15)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1878/files#diff-3">src/editor.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1878/files#diff-4">src/keybindings.c</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1878.patch'>https://github.com/geany/geany/pull/1878.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1878.diff'>https://github.com/geany/geany/pull/1878.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1878">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJyf51A1khBw6L2m_1KvUCzKMpfLgks5t9CIUgaJpZM4UqJsG">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ-U5uHush-IRwqndO3ErHqD0XaeOks5t9CIUgaJpZM4UqJsG.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany/pull/1878","url":"https://github.com/geany/geany/pull/1878","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Various fixes reported in #1876 (#1878)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1878"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Various fixes reported in #1876 (#1878)",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "46ee2a8",
"value": "Report subroutine declarations as such"
},
{
"name": "40fc677",
"value": "Add a sanity check on the Save As callback"
},
{
"name": "4641ce3",
"value": "Remove an unnecessary local variable"
},
{
"name": "99851b5",
"value": "Remove unused parameter"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[ctags/parsers/perl.c](https://github.com/geany/geany/pull/1878/files#diff-0) (1 changes)"
},
{
"name": "Modified",
"value": "[src/dialogs.c](https://github.com/geany/geany/pull/1878/files#diff-1) (1 changes)"
},
{
"name": "Modified",
"value": "[src/editor.c](https://github.com/geany/geany/pull/1878/files#diff-2) (15 changes)"
},
{
"name": "Modified",
"value": "[src/editor.h](https://github.com/geany/geany/pull/1878/files#diff-3) (2 changes)"
},
{
"name": "Modified",
"value": "[src/keybindings.c](https://github.com/geany/geany/pull/1878/files#diff-4) (2 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1878,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1878\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1878"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1878.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1878.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346594054\n}"
}
],
"themeColor": "26292E"
}</script>