<p><a class="user-mention" data-hovercard-user-id="1529109" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gntech">@gntech</a> Sorry, didn't notice this bug report earlier (better to <a class="user-mention" data-hovercard-user-id="713965" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> me because I'm not subscribed to receive all the comments for the project).</p>
<p>I would definitely support such a feature if anyone wants to implement it (on the other hand I probably won't have time for this myself). Some comments to such an implementation:</p>
<ol>
<li>
<p>The glob patterns are necessary for "find in files" because grep can only use these for the <code>--include=</code> command line option. So one would have to synthesize a glob version that would be some approximation of .gitignore rules.</p>
</li>
<li>
<p>In order to have the modified files information, it will probably be necessary to rewrite the project file tree code completely. It is completely static now and only changes when you refresh the project. I wrote it this way because I needed it for a huge project and wanted it to be as fast as possible (and having the implementation as simple as possible). I think it's possible to preserve a good performance even when there's some file monitoring (this is something I'd really like to have preserved for the plugin) but it definitely won't be trivial to implement right.</p>
</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/issues/740#issuecomment-397277550">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ57a87vM28PdC2RZ33OY367RyWgPks5t8lgcgaJpZM4T1DBJ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ09BQWtIvsIUm3HowycXyRhCTAQrks5t8lgcgaJpZM4T1DBJ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany-plugins/issues/740#issuecomment-397277550","url":"https://github.com/geany/geany-plugins/issues/740#issuecomment-397277550","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #740: @gntech Sorry, didn't notice this bug report earlier (better to @techee me because I'm not subscribed to receive all the comments for the project). \r\n\r\nI would definitely support such a feature if anyone wants to implement it (on the other hand I probably won't have time for this myself). Some comments to such an implementation:\r\n\r\n1. The glob patterns are necessary for \"find in files\" because grep can only use these for the `--include=` command line option. So one would have to synthesize a glob version that would be some approximation of .gitignore rules.\r\n\r\n2. In order to have the modified files information, it will probably be necessary to rewrite the project file tree code completely. It is completely static now and only changes when you refresh the project. I wrote it this way because I needed it for a huge project and wanted it to be as fast as possible (and having the implementation as simple as possible). I think it's possible to preserve a good performance even when there's some file monitoring (this is something I'd really like to have preserved for the plugin) but it definitely won't be trivial to implement right."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany-plugins/issues/740#issuecomment-397277550"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany-plugins] ProjectOrganizer: Option to get list of project files from git (#740)",
"sections": [
{
"text": "",
"activityTitle": "**Jiří Techet**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@techee",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 740,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 740\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/issues/740#issuecomment-397277550"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 332673097\n}"
}
],
"themeColor": "26292E"
}</script>