<p>It's partly interesting, but as every static analyzer it's at least half wrong, so it has to be used carefully, and it takes time.  For example, the first issue is both irrelevant and mostly wrong (it probably comes from the fact <code>Assert</code> is defined conditionally as a non-aborting check, which makes the analyzer incorrectly think the checked value can be <code>NULL</code>), and the third is totally wrong, which might be interesting to report to the authors (it wrongly assumes control flow could skip the body of a <code>while(1)</code> loop). <code>src/encodings.c:608: error: PREMATURE_NIL_TERMINATION_ARGUMENT</code> is also incorrect, because of the semantic of the "incriminated" function.</p>
<p>Anyway, thank you for this, but it has to be sorted out, as it's not very useful straight out of the analyzer.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1876#issuecomment-396585060">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ1Ma8vWF6bLzzOxzXPzrROKjlu6dks5t778FgaJpZM4UkTB6">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ5U4dzHxiMLay8rnOPPgKPwDP9CWks5t778FgaJpZM4UkTB6.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany/issues/1876#issuecomment-396585060","url":"https://github.com/geany/geany/issues/1876#issuecomment-396585060","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1876: It's partly interesting, but as every static analyzer it's at least half wrong, so it has to be used carefully, and it takes time.  For example, the first issue is both irrelevant and mostly wrong (it probably comes from the fact `Assert` is defined conditionally as a non-aborting check, which makes the analyzer incorrectly think the checked value can be `NULL`), and the third is totally wrong, which might be interesting to report to the authors (it wrongly assumes control flow could skip the body of a `while(1)` loop). `src/encodings.c:608: error: PREMATURE_NIL_TERMINATION_ARGUMENT` is also incorrect, because of the semantic of the \"incriminated\" function.\r\n\r\nAnyway, thank you for this, but it has to be sorted out, as it's not very useful straight out of the analyzer."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1876#issuecomment-396585060"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [geany/geany] Infer static analyzer report (#1876)",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1876,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1876\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/issues/1876#issuecomment-396585060"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 345059450\n}"
}
],
"themeColor": "26292E"
}</script>