<p><a class="user-mention" data-hovercard-user-id="181177" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/codebrainz">@codebrainz</a>, <a class="user-mention" data-hovercard-user-id="793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a>: thanks <g-emoji class="g-emoji" alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji> It seems to work fine.</p>
<p>To be more precise: it works for GTK2 and GTK3 if I compile locally on my machine. But as you can see the Travis CI build failed for GTK3. See the log at <a href="https://travis-ci.org/geany/geany-plugins/jobs/387902034" rel="nofollow">https://travis-ci.org/geany/geany-plugins/jobs/387902034</a>. It looks like vte-2.91 is not there:</p>
<pre><code>1459 checking for VTE... no
</code></pre>
<p>Later it also says:</p>
<pre><code>1739 Scope:                        no
</code></pre>
<p>Then it finally fails because the common utils lib is missing a check. How can I tell the utilslib to only compile file <code>gp_vtecompat.c</code> if vte-2.91 is there? That means if some other plugin requires vte-2.91 to be there, then compile <code>gp_vtecompat.c</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/750#issuecomment-394440720">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3-1q6DUAScGLjE4jxyt8eplpqkUks5t5XLngaJpZM4UYKVp">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJwud5OdRQvAhwFsPSDocoHWZCttTks5t5XLngaJpZM4UYKVp.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany-plugins/pull/750#issuecomment-394440720","url":"https://github.com/geany/geany-plugins/pull/750#issuecomment-394440720","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@LarsGit223 in #750: @codebrainz, @b4n: thanks :+1: It seems to work fine.\r\n\r\nTo be more precise: it works for GTK2 and GTK3 if I compile locally on my machine. But as you can see the Travis CI build failed for GTK3. See the log at https://travis-ci.org/geany/geany-plugins/jobs/387902034. It looks like vte-2.91 is not there:\r\n```\r\n1459 checking for VTE... no\r\n```\r\nLater it also says:\r\n```\r\n1739 Scope:                        no\r\n```\r\n\r\nThen it finally fails because the common utils lib is missing a check. How can I tell the utilslib to only compile file ```gp_vtecompat.c``` if vte-2.91 is there? That means if some other plugin requires vte-2.91 to be there, then compile ```gp_vtecompat.c```."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/750#issuecomment-394440720"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [geany/geany-plugins] scope: added GTK3 support (keeping GTK2 support) (#750)",
"sections": [
{
"text": "",
"activityTitle": "**LarsGit223**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@LarsGit223",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 750,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"pullRequestId\": 750\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/750#issuecomment-394440720"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 341878121\n}"
}
],
"themeColor": "26292E"
}</script>