<p><b>@msphn</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/geany/plugins.geany.org/pull/13#discussion_r191587296">index.php</a>:</p>
<pre style='color:#555'>> @@ -16,17 +16,20 @@
if (file_exists(CONTENTPATH . $_GET['site'] . '.html'))
{
define('CONTENTFILE', CONTENTPATH . $_GET['site'] . '.html');
+ define('PAGETITLE', $_GET['site']);
</pre>
<p>that's an easy XSS vul! you need to validate it before assigning it</p>
<hr>
<p>In <a href="https://github.com/geany/plugins.geany.org/pull/13#discussion_r191587396">index.php</a>:</p>
<pre style='color:#555'>> @@ -37,7 +40,7 @@
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
- <title>Plugins for Geany</title>
+ <title>Plugins for Geany [<?php print PAGETITLE ?>]</title>
</pre>
<p>here you just throw it out without escaping it, watch htmlspecialchars and so on</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/plugins.geany.org/pull/13#pullrequestreview-124188019">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ30vjhjE_nwlaWthLoT_ButO_TG0ks5t3cSNgaJpZM4USHsy">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ_c9HQt22dBWvi0xPGYpSd4ivqM2ks5t3cSNgaJpZM4USHsy.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/plugins.geany.org/pull/13#pullrequestreview-124188019","url":"https://github.com/geany/plugins.geany.org/pull/13#pullrequestreview-124188019","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/plugins.geany.org","title":"geany/plugins.geany.org","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/plugins.geany.org"}},"updates":{"snippets":[{"icon":"PERSON","message":"@msphn requested changes on #13"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/plugins.geany.org/pull/13#pullrequestreview-124188019"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "@msphn requested changes on 13",
"sections": [
{
"text": "",
"activityTitle": "**Michael Spahn**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@msphn",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/plugins.geany.org/pull/13#pullrequestreview-124188019"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 340294450\n}"
}
],
"themeColor": "26292E"
}</script>