<p><a class="user-mention" data-hovercard-user-id="181177" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/codebrainz">@codebrainz</a> Of course I tested it - I wouldn't be able to develop the plugin without it. And it really shouldn't affect plugins not using the signal so I'd say this one is very low risk. Of course there could be some discussion how to call this signal (I named it "key-press" for the lack of any better idea) or whether to implement it in a different way (I liked the idea of <a class="user-mention" data-hovercard-user-id="564520" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> but I didn't find a way how to achieve what I needed without a new signal).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1829#issuecomment-390679136">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ769AqP1aYXFOMDWzDczXaq3uUD-ks5t0tV_gaJpZM4TWsgF">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ2j4V84t6Nxfyf3qqLBaNIHc57bkks5t0tV_gaJpZM4TWsgF.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany/pull/1829#issuecomment-390679136","url":"https://github.com/geany/geany/pull/1829#issuecomment-390679136","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1829: @codebrainz Of course I tested it - I wouldn't be able to develop the plugin without it. And it really shouldn't affect plugins not using the signal so I'd say this one is very low risk. Of course there could be some discussion how to call this signal (I named it \"key-press\" for the lack of any better idea) or whether to implement it in a different way (I liked the idea of @kugel- but I didn't find a way how to achieve what I needed without a new signal)."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1829#issuecomment-390679136"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [geany/geany] Allow plugins to process keypress events before Geany (#1829)",
"sections": [
{
"text": "",
"activityTitle": "**Jiří Techet**",
"activityImage": "https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png",
"activitySubtitle": "@techee",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1829,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1829\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1829#issuecomment-390679136"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 324716549\n}"
}
],
"themeColor": "26292E"
}</script>