<p><b>@sardemff7</b> commented on this pull request.</p>

<p>If you don’t go with fallback checks, better drop the <code>#else</code>s. Other comments inside.</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/746#discussion_r189786629">markdown/src/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -35,4 +35,8 @@ markdown_la_CFLAGS += $(LIBMARKDOWN_CFLAGS)
 markdown_la_LIBADD += $(LIBMARKDOWN_LIBS)
 endif
 
+if MARKDOWN_WEBKIT2
+markdown_la_CFLAGS += -DMARKDOWN_WEBKIT2
</pre>
<p>Why not an <code>AC_DEFINE</code> in <code>markdown.m4</code> instead?</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/746#discussion_r189787130">build/markdown.m4</a>:</p>
<pre style='color:#555'>> @@ -49,13 +49,13 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
     GTK_VERSION=2.16
     WEBKIT_VERSION=1.1.13
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
</pre>
<p>It should work, but you better not add fallback code for unsupported versions, distributions with older packages will use older plugin too. (And people really must stop thinking everything will always work for them without patching on older systems, do not but the maintenance burden on you.)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/746#pullrequestreview-122031090">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwNLEIiRUYAIWyqKOf32bCzis9L7ks5t065ugaJpZM4UHqJZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ1H02gG4TFy796odXvOpIPVqVrgEks5t065ugaJpZM4UHqJZ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany-plugins/pull/746#pullrequestreview-122031090","url":"https://github.com/geany/geany-plugins/pull/746#pullrequestreview-122031090","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sardemff7 commented on #746"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/746#pullrequestreview-122031090"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "@sardemff7 commented on 746",
"sections": [
{
"text": "If you don’t go with fallback checks, better drop the `#else`s. Other comments inside.",
"activityTitle": "**Quentin Glidic**",
"activityImage": "https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png",
"activitySubtitle": "@sardemff7",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/746#pullrequestreview-122031090"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 337551961\n}"
}
],
"themeColor": "26292E"
}</script>