<p>To clarify my post above, I have tested that the change does NOT cause any problems in Geany.  Since plugins can be disabled, if it causes any problems with a plugin 1) the user can blame the plugin <g-emoji class="g-emoji" alias="grin" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f601.png">😁</g-emoji> and disable it 2) the plugin writer can supply a PR to fix the problem 3) after that is tested to not cause problems in Geany and applied 3) the user can re-enable the plugin.  (repeat until plugin works)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1829#issuecomment-390371934">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwPJi0rjRzws-NQLSEUFCMklBanPks5tz4J2gaJpZM4TWsgF">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ5gRBY0CR9xF14rFSryVfFq6FS90ks5tz4J2gaJpZM4TWsgF.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany/pull/1829#issuecomment-390371934","url":"https://github.com/geany/geany/pull/1829#issuecomment-390371934","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1829: To clarify my post above, I have tested that the change does NOT cause any problems in Geany.  Since plugins can be disabled, if it causes any problems with a plugin 1) the user can blame the plugin :grin: and disable it 2) the plugin writer can supply a PR to fix the problem 3) after that is tested to not cause problems in Geany and applied 3) the user can re-enable the plugin.  (repeat until plugin works)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1829#issuecomment-390371934"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [geany/geany] Allow plugins to process keypress events before Geany (#1829)",
"sections": [
{
"text": "",
"activityTitle": "**elextr**",
"activityImage": "https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png",
"activitySubtitle": "@elextr",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany\",\n\"issueId\": 1829,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany\",\n\"pullRequestId\": 1829\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany/pull/1829#issuecomment-390371934"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 324716549\n}"
}
],
"themeColor": "26292E"
}</script>