<p>All the changed documents have already been saved (or the user has elected to not save) as part of the shutdown process and the changed status deliberately changed to false.  Things in Geany and plugins may depend on the "unchanged" status to prevent them doing stuff when the document is closed at shutdown.</p>
<p>You should look at why it was added, and if any Geany functions or current known plugins depend on those semantics.  If it was added pre-git any discussions may not have been transferred from SVN, but they may also have happened on the dev ML, so the archive would need to be checked around the date the function was added.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1857#issuecomment-389757906">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9MmIxRukJgjypfJRo-b5kqPMepEks5tzRcjgaJpZM4T82nj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ3P8ZnFluu3kVba8wf_JLN-dZRcZks5tzRcjgaJpZM4T82nj.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1857#issuecomment-389757906"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1857: All the changed documents have already been saved (or the user has elected to not save) as part of the shutdown process and the changed status deliberately changed to false.  Things in Geany and plugins may depend on the \"unchanged\" status to prevent them doing stuff when the document is closed at shutdown.\r\n\r\nYou should look at why it was added, and if any Geany functions or current known plugins depend on those semantics.  If it was added pre-git any discussions may not have been transferred from SVN, but they may also have happened on the dev ML, so the archive would need to be checked around the date the function was added.\r\n\r\n\r\n\r\n\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1857#issuecomment-389757906"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [geany/geany] Fix 'changed' flag being altered when all documents are closing. (#1857)","sections":[{"text":"","activityTitle":"**elextr**","activityImage":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","activitySubtitle":"@elextr","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"geany/geany\",\"issueId\":1857,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"geany/geany\",\"pullRequestId\":1857}"},{"targets":[{"os":"default","uri":"https://github.com/geany/geany/pull/1857#issuecomment-389757906"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":334719459}"}],"themeColor":"26292E"}</script>