<p>I'm hazy on what LGBI means. As to squashing commits, I'm happy to do that, but I'm not sure what the accepted best practice is on an open PR. Is a forced push overwriting the existing commits with a combined one OK, or should a new PR be opened based off a new branch, the existing PR modified to pull from a new branch, or something else? The Geany hacking document does not specify this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1820#issuecomment-386915226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJyN1oDzpFDvJ2kcy5XuBSYhIIJgSks5tv2mGgaJpZM4TKL22">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJylE1_gAAtMVnKUdki7fWLvgMdEcks5tv2mGgaJpZM4TKL22.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1820#issuecomment-386915226"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tambeta in #1820: I'm hazy on what LGBI means. As to squashing commits, I'm happy to do that, but I'm not sure what the accepted best practice is on an open PR. Is a forced push overwriting the existing commits with a combined one OK, or should a new PR be opened based off a new branch, the existing PR modified to pull from a new branch, or something else? The Geany hacking document does not specify this. "}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1820#issuecomment-386915226"}}}</script>