<p>Don't worry, the squash can be done at merge, but the reminder is always good.  I take it that upstream ctags accepted the change.</p>
<p>Can you add a test for this?  See <code>geany/tests/ctags</code> basically a short piece of ruby and the expected tags.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1820#issuecomment-386923191">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7pD3p4WSzQrBlDyvpB0rX2mwoDgks5tv39ngaJpZM4TKL22">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ-2yS7Xg7m1RUvu_oEDEt1s7y4Gxks5tv39ngaJpZM4TKL22.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1820#issuecomment-386923191"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1820: Don't worry, the squash can be done at merge, but the reminder is always good.  I take it that upstream ctags accepted the change.\r\n\r\nCan you add a test for this?  See `geany/tests/ctags` basically a short piece of ruby and the expected tags."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1820#issuecomment-386923191"}}}</script>