<p><b>@pcworld</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/735#discussion_r183198068">vimode/src/keypress.c</a>:</p>
<pre style='color:#555'>> + * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+
+#include "keypress.h"
+#include "utils.h"
+
+#include <gdk/gdkkeysyms.h>
+
+KeyPress *kp_from_event_key(GdkEventKey *ev)
+{
+       guint mask = GDK_MODIFIER_MASK & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK | GDK_CONTROL_MASK);
+       KeyPress *kp;
+
+       if (ev->state & mask)
+               return NULL;
</pre>
<p>I found the cause of my issue with vimode not recognizing keypresses. I have num lock enabled, which maps to <a href="https://github.com/GNOME/gtk/blob/cfa04805a327300056b7cfb5b3c127e667b8f4c3/gdk/gdktypes.h#L230"><code>GDK_MOD2_MASK</code></a> in GDK in X11 (in my configuration at least). The following patch fixes it for me, however an even less restrictive mask might be appropriate in order to avoid further false positives:</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-md">--- a/vimode/src/keypress.c</span>
<span class="pl-mi1">+++ b/vimode/src/keypress.c</span>
<span class="pl-mdr">@@ -23,7 +23,7 @@</span>
 
 KeyPress *kp_from_event_key(GdkEventKey *ev)
 {
<span class="pl-md"><span class="pl-md">-</span>       guint mask = GDK_MODIFIER_MASK & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK | GDK_CONTROL_MASK);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>       guint mask = GDK_MODIFIER_MASK & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK | GDK_CONTROL_MASK | GDK_MOD2_MASK);</span>
        KeyPress *kp;
 
        if (ev->state & mask)</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/735#pullrequestreview-114160590">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxUZZSc_Tg4g3RcyUXEG4-EjWiUoks5tqp37gaJpZM4TWsaH">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ4kpzdxg6TfKIksImqfCnKmPyA_2ks5tqp37gaJpZM4TWsaH.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/735#pullrequestreview-114160590"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pcworld commented on #735"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/735#pullrequestreview-114160590"}}}</script>